Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a 500 error in i18n default_copyright #90

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

OmarIthawi
Copy link
Contributor

@OmarIthawi OmarIthawi commented Aug 7, 2019

Fix a 500 error, the function name was written incorrectly.

Also ensure that the default_text is chosen when there's not translation.

@OmarIthawi OmarIthawi changed the title (WIP) Fix a 500 error in i18n default_copyright Fix a 500 error in i18n default_copyright Aug 7, 2019
Copy link

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's involved in writing a test for this?

@OmarIthawi
Copy link
Contributor Author

OmarIthawi commented Aug 7, 2019

I don't know how to write tests inside the theme @johnbaldwin!

We need tests! #91

@OmarIthawi OmarIthawi merged commit e0b0c03 into hawthorn/tahoe Aug 7, 2019
@OmarIthawi OmarIthawi deleted the omar/fix-500-error-i18n branch October 7, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants